Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing AgentProtocols #592

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Removing AgentProtocols #592

merged 1 commit into from
Oct 28, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 22, 2024

Reverting #210. Contingent on jenkinsci/jenkins#9903 being merged.

@MarkEWaite MarkEWaite mentioned this pull request Oct 28, 2024
Merged
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Oct 28, 2024
@MarkEWaite
Test with support-core 1517.v68694b_0ffb_10
473c551 
jenkinsci/support-core-plugin#592
@MarkEWaite MarkEWaite mentioned this pull request Oct 28, 2024
Closed
6 tasks
@jglick jglick marked this pull request as ready for review October 28, 2024 17:26
@jglick jglick requested a review from a team as a code owner October 28, 2024 17:26
MarkEWaite
MarkEWaite approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Passes the plugin BOM with an incremental build of 2.483

I was a little bit surprised that the AgentProtocols reference in the CasCTest did not need to be changed. I assume that is because this is not yet testing with Jenkins 2.483 or with configuration as code that drops AgentProtocols

@jglick
Copy link
Member Author

jglick commented Oct 28, 2024

I suppose that means that the CasC setter here does not verify that the ids being requested are actually legitimate components, so typos etc. would be quietly ignored.

@jglick jglick added this pull request to the merge queue Oct 28, 2024
Merged via the queue into jenkinsci:master with commit a992a08 Oct 28, 2024
17 checks passed
@jglick jglick deleted the AgentProtocols branch October 28, 2024 17:59
@daniel-beck
Copy link
Member

This seems wrong without a newer core dependency preventing installation on older cores for which this may provide useful information.

@jglick
Copy link
Member Author

jglick commented Oct 29, 2024

I suspect this component was rarely looked at to begin with. It did not seem worth the effort of writing it to display information only on older cores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @daniel-beck @MarkEWaite