Computer.toNode() can return null #25
Conversation
|
This looks alright, but there is some whitespace lingering, could you strip them away? 😄 |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
👍 |
| final Slave node = computer.getNode(); | ||
| if (node != null) { | ||
| try { | ||
| Jenkins.getInstance().removeNode(node); |
There was a problem hiding this comment.
Minor: This method call also can return null. It should not happens in the handler, but FindBugs and other guys will complain
There was a problem hiding this comment.
Not on Jenkins 1.480 which is what swarm is based on ;-)
|
@mindjiver this pull request has now successfully completed the CloudBees internal processes and we are now asking you, as the maintainer of the plugin for any additiona feedback with a view towards merging and cutting a new release with this fix |
Computer.toNode() can return null
|
@mindjiver thank you |
|
@stephenc The plugin should be released now, I'm updating the release information on the wiki |
@reviewbybees