Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the modifiers #86

Merged
merged 5 commits into from
May 21, 2019
Merged

Reorder the modifiers #86

merged 5 commits into from
May 21, 2019

Conversation

xuejiangtao
Copy link
Contributor

@xuejiangtao xuejiangtao commented May 21, 2019

@calphool
i found several Code Smells and fixed them.
The Java Language Specification recommends listing modifiers in the following order:

  1. Annotations

  2. public

  3. protected

  4. private

  5. abstract

  6. static

  7. final

  8. transient

  9. volatile

  10. synchronized

  11. native

  12. strictfp

Not following this convention has no technical impact, but will reduce the code's readability because most developers are used to the standard order.

see https://rules.sonarsource.com/java/RSPEC-1124

@basil basil merged commit 1ef058f into jenkinsci:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants