[JENKINS-72358] Replace Prototype.js $(var) with var

[MarkEWaite]

[JENKINS-72358] Replace Prototype.js $(var) with var

JENKINS-72358 reports a JavaScript error when the plus sign is clicked to expand the test results analyzer tree.

The blog post recommends replacing $(variable) with variable. That's what I did in 3 cases in this change.

I've confirmed that the JavaScript message that was displayed with the released version of the plugin is not displayed with these changes.

Testing done

Interactively verified that I could see the JavaScript warning messages in the web developer console before this change and that the warning messages did not appear after the change. The UI behaved incorrectly before the change and behaved correctly after the change.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

@gounthar you are currently a maintainer of this plugin. Would you be willing to review and merge this pull request?

[gounthar]

Thank you, Mark. It looks good to me, at least with my understanding of JS.

[Pexkoh]

Hi @gounthar,
Thank you for merging Mark’s pull request – it fixed the problem we had with the plugin on our Jenkins server.

I’m pretty new to Jenkins so I hope you don’t mind me asking – is it planned to add the current fix to the official Jenkins plugin releases (if you have the necessary access to change the .hpi file)?
This way we could continue using the official plugin and still receive potential updates if someone decides to adopt and extend it.

I appreciate the help!

[gounthar]

Let's see if Mark and I can publish a release today. 🤞

[gounthar]

I’m pretty new to Jenkins so I hope you don’t mind me asking – is it planned to add the current fix to the official Jenkins plugin releases (if you have the necessary access to change the .hpi file)? This way we could continue using the official plugin and still receive potential updates if someone decides to adopt and extend it.

Absolutely, it's perfectly normal and welcome to ask for a release when a fix you're looking for gets merged. Your input is valuable, and we appreciate your interest in using Jenkins and this plugin. 🚀

Feel free to reach out if you have any more questions or if there's anything else you'd like to discuss.

[gounthar]

The release 0.41.0 is available, thanks to the joint efforts of Mark and myself. 🚀

[Pexkoh]

Thanks a lot for the released version and the lightning fast reactions 😉 I really appreciate the efforts from both of you and the kind words!