Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding platform management #8

Merged
merged 1 commit into from
Sep 13, 2013
Merged

adding platform management #8

merged 1 commit into from
Sep 13, 2013

Conversation

maBergaoui
Copy link
Contributor

No description provided.

@maBergaoui
Copy link
Contributor Author

Sorry for the mess... I'm new with git :)

@buildhive
Copy link

Jenkins » testlink-plugin #43 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@kinow
Copy link
Member

kinow commented Sep 6, 2013

Hi @maBergaoui! Have you tested your changes with a project with multiple platforms? Say you have platforms for browsers, and then you have IE, Chrome and Firefox...

@maBergaoui
Copy link
Contributor Author

I tested it on an android project using a real phone and 2 emulators. The test was made on a cross platform project on Jenkins (the tests were simultaneous)

@kinow
Copy link
Member

kinow commented Sep 6, 2013

Sorry, I think I didn't make myself clear. What I meant was if you tried your code with 2 or more platforms created in TestLink, and assigned to the test plan?

@maBergaoui
Copy link
Contributor Author

Yes. I created 3 platforms in TestLink (phone1, emulator1 and emulator2) and assigned them to the test plan. Then i launched the tests via Jenkins and the result results were successfully updated in TestLink for each platform.

@kinow
Copy link
Member

kinow commented Sep 6, 2013

Hmm, and you created one job for each platform? Or did you use a matrix job? :D

I'm starting to feel that you've found the solution for a long time problem that I've been struggling to fix in the plug-in

@maBergaoui
Copy link
Contributor Author

It was a matrix job with an axis that i called platformName
In the testLink config part in Jenkins I just had to put ${platformName} in the field I added to the plugin.

@kinow
Copy link
Member

kinow commented Sep 6, 2013

That's brilliant!

I'll give it a try and will merge it :D thanks @maBergaoui !

After I created the plug-in, I discovered that it didn't work with platforms... I tried fixing in 1.x, later in 2.x, and finally implemented platforms with TAP + YAMLish. But I had to specify the platform in the test result, and it only worked with TAP.

Now, with your solution (that now seems like the obvious one for me) we can finally have platforms in testlink-plugin in a simple and neat way.

Thanks a lot @maBergaoui! :D have a super weekend! 👍

@maBergaoui
Copy link
Contributor Author

Thank you :) Have a nice weekend :D

@kinow
Copy link
Member

kinow commented Sep 13, 2013

@maBergaoui, I'll try to merge it this weekend :D stay tuned, thanks again!

kinow added a commit that referenced this pull request Sep 13, 2013
adding platform management
@kinow kinow merged commit 408f220 into jenkinsci:master Sep 13, 2013
@kinow
Copy link
Member

kinow commented Sep 13, 2013

Merged and running some tests. Will cut a release this weekend with this change too :-) thanks for your patience and contribution.

@maBergaoui
Copy link
Contributor Author

my pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants