[JENKINS-71810] Token Macro tests fail on Java 21 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slide
approved these changes
Aug 11, 2023
MarkEWaite
added a commit
to MarkEWaite/schedule-build-plugin
that referenced
this pull request
Aug 12, 2023
Java 21 changed the date format to use a narrow no-break space, so the regular expression used in the tests now fails to match. Changed the test to use the '\h' character class, which matches. jenkinsci/token-macro-plugin#191 uses the same technique to handle test compatibility between Java 11, Java 17, and Java 21.
8 tasks
MarkEWaite
added a commit
to jenkinsci/schedule-build-plugin
that referenced
this pull request
Aug 13, 2023
Java 21 changed the date format to use a narrow no-break space, so the regular expression used in the tests now fails to match. Changed the test to use the '\h' character class, which matches. jenkinsci/token-macro-plugin#191 uses the same technique to handle test compatibility between Java 11, Java 17, and Java 21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-71810. Java 21 changed the date format to use a narrow no-break space, so the regular expression used in the tests now fails to match. Changed the test to use the
\hcharacter class, which matchesTesting done
Ran the tests on Java 11, 17, and 21. Before this PR, Java 21 failed. After this PR, all Java versions are passing.
Bonus
While I was here, I updated the test to use Hamcrest matchers for a more readable error message if the test fails.