-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use json-path api plugin #204
Conversation
Can you please sign the commits? |
Signed-off-by: Valentin Delaye <jonesbusy@gmail.com>
94595f9
to
cb988be
Compare
@slide Done. I've also updated to new bom version 2643.vfa_93ff299d20 which include the API in the bom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Removes the bundling of the direct dependency json-path
which then avoids the bundling of two transient dependencies, accessors-smart
and json-smart
@slide could you label this as "developer" or as "enhancement" so that it result in a release? |
Hello! The output is:
Could this release have caused something to break? |
What update center are you using? The update center that I just looked at had the json-path-api plugin, maybe the one you're using does not have it synced yet? |
From the looks of it, i'm using the default https://updates.jenkins.io/update-center.json. |
I don't have the same behavior with update center. Plugin is pull after update But is possible that token macro must be bumped on some plugin in order for transitive resolution to work. I don't know enough plugin manager tool to understand what's causing this |
Just checked https://updates.jenkins.io/dynamic-stable-2.414.1/update-center.json as well,
it does seem to have Perhaps this should be filed against jenkins-plugin-manager. Thanks a bunch! |
I'm able to see the same unexpected failure when I run the following script with no dependencies on files outside the script: #!/bin/bash
# Token macro dependency on json-path-api
#
# https://github.com/jenkinsci/token-macro-plugin/pull/204
JENKINS_WAR_VERSION=2.414.1
JENKINS_WAR=jenkins-${JENKINS_WAR_VERSION}.war
PLUGIN_MANAGER_VERSION=2.12.13
PLUGIN_MANAGER_JAR=jenkins-plugin-manager-${PLUGIN_MANAGER_VERSION}.jar
if [ ! -f ../$PLUGIN_MANAGER_JAR ]; then
wget https://github.com/jenkinsci/plugin-installation-manager-tool/releases/download/${PLUGIN_MANAGER_VERSION}/$PLUGIN_MANAGER_JAR
mv $PLUGIN_MANAGER_JAR ..
fi
if [ ! -d plugins ]; then
mkdir plugins
fi
java -jar ../$PLUGIN_MANAGER_JAR --jenkins-version $JENKINS_WAR_VERSION --latest true --plugin-download-directory plugins -p blueocean
if [ ! -f ../$JENKINS_WAR ]; then
wget https://get.jenkins.io/war-stable/${JENKINS_WAR_VERSION}/jenkins.war
mv jenkins.war ../$JENKINS_WAR
fi
JENKINS_HOME=. java -jar ../$JENKINS_WAR Since the dependency on |
Yup, will do! (Perhaps when i wake up in a few hours) thanks for confirming @MarkEWaite ! |
Use json-path api plugin
Testing done
Submitter checklist