JENKINS-60999: Add support for a new parameter tailMaxCount for BUILD_LOG_REGEX token #41
Conversation
| return defaultValue; | ||
| } | ||
| return buffer.toString(); | ||
| if (maxTailMatches > 0 && matchResults.size() > maxTailMatches) { | ||
| matchResults = matchResults.subList(matchResults.size() - maxTailMatches, matchResults.size()); |
There was a problem hiding this comment.
What happens if it is in the middle of a <pre></pre> and cuts off? See the insidePre checks above. I think we would want to make sure that a </pre> gets added at the end if one is needed.
There was a problem hiding this comment.
Thanks for pointing that out, let me look into the right handling for this case.
There was a problem hiding this comment.
I addressed your concern, please let me know if you have any other feedback.
| return buffer.toString(); | ||
| if (maxTailMatches > 0 && matchResults.size() > maxTailMatches) { | ||
| int tailStartLocation; | ||
| if (asHtml) { |
There was a problem hiding this comment.
@slide I was considering to handle this like how the truncated lines are handled in the else case, but this will become unreliable if there are pre blocks in the log output itself, so decided to not do it. Please let me know if you think otherwise.
Included a fix (and test cases) for a edge case scenario of using
greedy=falsewith defaultmaxCount. Also added missing documentation forgreedy.