[JENKINS-62552] Use standard crypto APIs #45
Conversation
This deprecates the included implementations of block ciphers in preference of the ones bundled with the JDK. Signed-off-by: Matt Sicker <boards@gmail.com>
|
Alright, there we go, passing CI. |
| /** | ||
| * BlockCipher that delegates cryptographic operations to {@code javax.crypt.Cipher}. | ||
| */ | ||
| public class JreCipherWrapper implements BlockCipher { |
There was a problem hiding this comment.
this is a new class a unit test is recommended
Signed-off-by: Matt Sicker <boards@gmail.com>
|
So far I've verified this works with my remote Debian machine. I'm trying it out now with |
|
I should note that I'm using an Ed25519 key for authentication in both operating systems (the same key actually, just different usernames). |
|
And the Windows/OpenSSH method also seems to work fine. |
| try { | ||
| cipher.init(mode, new SecretKeySpec(key, algorithm), parameterSpec); | ||
| } catch (InvalidKeyException | InvalidAlgorithmParameterException e) { | ||
| throw new IllegalArgumentException(e); |
There was a problem hiding this comment.
Would it make more sense to let the actual exceptions bubble up?
There was a problem hiding this comment.
They're checked exceptions (all subclassing GeneralSecurityException). :/
There was a problem hiding this comment.
I was thinking they could just be added here, but it doesn't look like it.
There was a problem hiding this comment.
Right, not without changing the API, and the interface (and deprecated code) is copied from Bouncycastle as it is.
|
@kuisathaverat can I get a re-review? |
|
@kuisathaverat Any news? ^^ (we are still keeping track of this issue in our board ;) ) |
|
Thanks! |
This reverts commit 4aada2d.
This deprecates the included implementations of block ciphers in preference of the ones bundled with the JDK.
Signed-off-by: Matt Sicker boards@gmail.com
@jeffret-b @daniel-beck @Wadeck