Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: which test is stuck #53

Merged
merged 14 commits into from
Oct 4, 2020

Conversation

kuisathaverat
Copy link
Contributor

this job takes 4 hours on CI, locally it takes less than 5 min so something does not work on the CI as expected

@kuisathaverat
Copy link
Contributor Author

confirmed the 4hours block in a test was because the SecureRandom.getInstanceStrong();

cc @jvz

@kuisathaverat kuisathaverat marked this pull request as ready for review October 4, 2020 20:59
@kuisathaverat kuisathaverat merged commit ed4ecdb into jenkinsci:master Oct 4, 2020
@jvz
Copy link
Member

jvz commented Oct 5, 2020

Should we use some sort of SecureRandomProvider interface to abstract that out? Use of the "slow" initializing random generator is probably correct behavior in production, but unnecessary in tests (I usually use a static seed for random number generators in unit tests).

@kuisathaverat
Copy link
Contributor Author

Should we use some sort of SecureRandomProvider interface to abstract that out? Use of the "slow" initializing random generator is probably correct behavior in production, but unnecessary in tests (I usually use a static seed for random number generators in unit tests).

SecureRandom instance uses the default algorithm that is fast so I think is fine, we use it on other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants