Remove icon from reference link as it is broken in core again.

jenkinsci · Feb 29, 2024 · 6a1cbad · 6a1cbad
1 parent cb0172f
commit 6a1cbad
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/SummaryModel.java b/plugin/src/main/java/io/jenkins/plugins/analysis/core/model/SummaryModel.java
@@ -10,6 +10,7 @@
 
 import hudson.model.Run;
 
+import io.jenkins.plugins.forensics.reference.ReferenceBuild;
 import io.jenkins.plugins.util.QualityGateStatus;
 
 /**
@@ -155,6 +156,18 @@ public boolean isResetQualityGateVisible() {
         return analysisResult.getReferenceBuild();
     }
 
+    /**
+     * Renders the reference build as an HTML link.
+     *
+     * @return the reference build
+     * @see #getReferenceBuild()
+     */
+    @SuppressWarnings("unused") // Called by jelly view
+    public String getReferenceBuildLink() {
+        return ReferenceBuild.getReferenceBuildLink(
+                analysisResult.getReferenceBuild().map(Run::getExternalizableId).orElse("-"));
+    }
+
     public boolean isZeroIssuesHighscore() {
         return getNoIssuesSinceBuild() > 0 && analysisResult.getOwner().getNumber() > getNoIssuesSinceBuild();
     }

diff --git a/plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly b/plugin/src/main/resources/io/jenkins/plugins/analysis/core/model/ResultAction/summary.jelly
@@ -99,7 +99,7 @@
           <j:set var="r" value="${s.referenceBuild.get()}"/>
           <li>
             Reference build:
-            <t:buildLink jobName="${r.parent.displayName}" job="${r.parent}" number="${r.number}"/>
+            <j:out value="${s.referenceBuildLink}"/>
           </li>
         </j:if>
         <j:if test="${s.qualityGateStatus.name() != 'INACTIVE'}">