Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up forkCount fix from acceptance-test-harness #1332

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 11, 2022

Follows up #1327 by picking up jenkinsci/acceptance-test-harness#885. Would appreciate a release. @basil @uhafner

@uhafner
Copy link
Member

uhafner commented Aug 11, 2022

How does a release of the warnings plugin help here? A release currently is executed in the plugin folder only. The UI tests are not affected by a release up to now. Or how do you use the UI tests together with the plugin in your PCT? Wouldn't it make more sense to simply ignore the UI tests in PCT?

@jglick
Copy link
Member Author

jglick commented Aug 11, 2022

Currently the UI tests do seem to get run in PCT. Perhaps it would make sense to ignore them, but I would need to explore how to do that. At any rate, it seems worth a shot at having them just pass.

@jglick
Copy link
Member Author

jglick commented Aug 11, 2022

How does a release of the warnings plugin help here?

Simply by having a different release tag. PCT checks out plugin sources from the version tag before running tests.

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1332 (8b5ab73) into master (42a03ba) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1332   +/-   ##
=========================================
  Coverage     79.78%   79.78%           
  Complexity     1448     1448           
=========================================
  Files           251      251           
  Lines          5611     5611           
  Branches        427      427           
=========================================
  Hits           4477     4477           
  Misses          983      983           
  Partials        151      151           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner added dependencies Update of dependencies java Pull requests that update Maven Java dependencies labels Aug 11, 2022
@uhafner uhafner merged commit d985dec into jenkinsci:master Aug 11, 2022
@jglick jglick deleted the forkCount branch August 11, 2022 14:41
@uhafner
Copy link
Member

uhafner commented Aug 11, 2022

Release is in progress...

@jglick
Copy link
Member Author

jglick commented Aug 11, 2022

@jglick
Copy link
Member Author

jglick commented Aug 11, 2022

jenkinsci/acceptance-test-harness#885 (comment) I guess this was merged without CI passing?

@uhafner
Copy link
Member

uhafner commented Aug 11, 2022

Yes, I thought it is urgent to get the release out. Since there were no changes in the plugin I thought that it was safe. Since GitHub actions sometimes have problems when accessing Jenkins resources I thought it would not harm.

@jglick
Copy link
Member Author

jglick commented Aug 11, 2022

Well I certainly appreciate the prompt response, but it looks like this was actually broken. 😬

@jglick
Copy link
Member Author

jglick commented Aug 11, 2022

@uhafner
Copy link
Member

uhafner commented Aug 11, 2022

https://github.com/jenkinsci/warnings-ng-plugin/releases/tag/v9.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies java Pull requests that update Maven Java dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants