-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up forkCount
fix from acceptance-test-harness
#1332
Conversation
How does a release of the warnings plugin help here? A release currently is executed in the |
Currently the UI tests do seem to get run in PCT. Perhaps it would make sense to ignore them, but I would need to explore how to do that. At any rate, it seems worth a shot at having them just pass. |
Simply by having a different release tag. PCT checks out plugin sources from the version tag before running tests. |
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
=========================================
Coverage 79.78% 79.78%
Complexity 1448 1448
=========================================
Files 251 251
Lines 5611 5611
Branches 427 427
=========================================
Hits 4477 4477
Misses 983 983
Partials 151 151 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Release is in progress... |
jenkinsci/acceptance-test-harness#885 (comment) I guess this was merged without CI passing? |
Yes, I thought it is urgent to get the release out. Since there were no changes in the plugin I thought that it was safe. Since GitHub actions sometimes have problems when accessing Jenkins resources I thought it would not harm. |
Well I certainly appreciate the prompt response, but it looks like this was actually broken. 😬 |
Follows up #1327 by picking up jenkinsci/acceptance-test-harness#885. Would appreciate a release. @basil @uhafner