Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @POST for form field validation #702

Merged
merged 3 commits into from
Nov 29, 2020
Merged

Use @POST for form field validation #702

merged 3 commits into from
Nov 29, 2020

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 28, 2020

Downstream PR of jenkinsci/plugin-util-api-plugin#66.

Use @POST for field validation. For details see https://www.jenkins.io/doc/developer/security/form-validation/.

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #702 (ee77bb9) into master (ea7f43d) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #702      +/-   ##
============================================
+ Coverage     80.72%   80.74%   +0.01%     
  Complexity     1502     1502              
============================================
  Files           240      240              
  Lines          5406     5405       -1     
  Branches        371      371              
============================================
  Hits           4364     4364              
+ Misses          886      885       -1     
  Partials        156      156              
Impacted Files Coverage Δ Complexity Δ
...ins/plugins/analysis/core/filter/RegexpFilter.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...lugins/analysis/core/model/ReportScanningTool.java 84.05% <ø> (ø) 19.00 <0.00> (ø)
...a/io/jenkins/plugins/analysis/core/model/Tool.java 74.28% <ø> (ø) 10.00 <0.00> (ø)
...ns/analysis/core/steps/AnalysisStepDescriptor.java 18.18% <ø> (+1.51%) 1.00 <0.00> (ø)
...ns/plugins/analysis/core/steps/IssuesRecorder.java 73.30% <ø> (+0.65%) 79.00 <0.00> (ø)
...lugins/analysis/warnings/axivion/AxivionSuite.java 3.48% <ø> (ø) 0.00 <0.00> (ø)
...lysis/warnings/axivion/RemoteAxivionDashboard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...plugins/analysis/warnings/groovy/GroovyParser.java 73.72% <ø> (ø) 16.00 <0.00> (ø)
...ins/plugins/analysis/warnings/tasks/OpenTasks.java 40.29% <ø> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7f43d...ee77bb9. Read the comment docs.

@uhafner uhafner merged commit 2b1a3c1 into master Nov 29, 2020
@uhafner uhafner deleted the do-validate-with-post branch November 29, 2020 10:03
@uhafner uhafner added the bug Bugs or performance problems label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant