Add Declarative to aggregator #16
Conversation
Note that this is deliberately not using workflow-multibranch 2.10, since that depends on branch-api 2.0.0 and that's a problematic release. Dependency versions bumped to match those in pipeline-model-definition's 1.0 release, along with reasonable updates of plugins that aren't Declarative dependencies. This does require moving to core 2.7.1 as well.
pom.xml
Outdated
| @@ -63,23 +63,23 @@ | |||
| </pluginRepository> | |||
| </pluginRepositories> | |||
| <properties> | |||
| <jenkins.version>1.642.3</jenkins.version> | |||
| <jenkins.version>2.7.1</jenkins.version> | |||
There was a problem hiding this comment.
I think 2.7.3 would be more appropriate.
There was a problem hiding this comment.
That would require Blue Ocean to bump their minimum (which is 2.7.1 currently)
There was a problem hiding this comment.
Maybe BO should require 2.7.3?
There was a problem hiding this comment.
Why not just stick with 2.7.1? That's the first LTS release of 2.x, it's what Declarative and BO depend on, we generally stick to depending on the earliest possible LTS release rather than a later one, etc. I know of no reason to depend on 2.7.3 rather than 2.7.1.
There was a problem hiding this comment.
I also would prefer 2.7.3. For Pipeline plugins we generally depend on the most recent update in a given LTS line. This ensures that tests etc. are incorporating known fixes.
There was a problem hiding this comment.
Ok, I'll bump it to 2.7.3 - neither BO nor Declarative depend on workflow-aggregator, so they're not going to get messed up by bumping the aggregator core dependency.
|
🐝 |
It depends on git 3.0.2, which is part of the suite of blocked releases from the branch-api 2.0 fallout.
|
Just realized that pipeline-github-lib 1.0 brought in git 3.0.2 and that whole mess, so I removed that plugin completely. |
|
I would also like to bump up dependencies in the |
Yes, #13 was a problem. Really should have waited for a (non-beta) release. |
|
The demo was actually more up to date than the aggregator. =) |
|
🐝 |
Note that this is deliberately not using workflow-multibranch 2.10,
since that depends on branch-api 2.0.0 and that's a problematic
release.
Dependency versions bumped to match those in
pipeline-model-definition's 1.0 release, along with reasonable updates
of plugins that aren't Declarative dependencies. This does require
moving to core 2.7.1 as well.
cc @reviewbybees esp @jglick