Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use detached JavaMail plugin #167

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Use detached JavaMail plugin #167

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
995353a
Use detached plugin
basil Jan 8, 2022
7c2cd34
Merge remote-tracking branch 'origin/master' into javamail-upgrade
basil Jan 21, 2022
6740f10
Bump plugin BOM from 1090.v0a_33df40457a_ to 1117.v62a_f6a_01de98
basil Jan 21, 2022
45ae386
Use released version of Jenkins core
basil Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<properties>
<revision>2.25</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.263.1</jenkins.version>
<jenkins.version>2.331</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should refrain using non LTS this prevents users use last version of the plugin....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So? If and when there is some important feature/fix that cannot wait for the next LTS line, https://gist.github.com/jglick/86a30894446ed38f918050c1180483e2 is easy enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not but it's not something so simple and probably not obvious for the majority of the plugins maintainers.
probably worth some documentation somewhere.
how do that work with CD?
does the cd tooling can detect he needs to generate something between 23343_kljffe0345 and 53343_kljloe0345?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth some documentation somewhere.

Agreed.

how do that work with CD?

The same Gist shows an example. Again, yes, deserves formal documentation and perhaps some tooling to make it easier and more discoverable.

<java.level>8</java.level>
<useBeta>true</useBeta>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
Expand All @@ -73,8 +73,8 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.263.x</artifactId>
<version>984.vb5eaac999a7e</version>
<artifactId>bom-weekly</artifactId>
<version>1117.v62a_f6a_01de98</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Expand Down Expand Up @@ -143,6 +143,12 @@
<artifactId>javadoc</artifactId>
<version>1.6</version>
<scope>test</scope>
<exclusions>
<exclusion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything filed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

<groupId>org.jenkins-ci</groupId>
<artifactId>symbol-annotation</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Expand Down