add pwsh step

[jetersen]

downstream of jenkinsci/durable-task-plugin#111

Hmm, should I add docker fixture or testcontainers or hope that our Windows server 2019 have pwsh?

[car-roll]

I'm fine with either

[gabloe]

@Casz the Windows Server Images likely do not have open powershell (pwsh) installed

[gabloe]

This looks good to me.

[jetersen]

I think the testing done in upstream should suffice, if anyone disagree. I can copy the same test here 😓

[jetersen]

I updated it to use the released version, so a mighty release of this would be appreciated @dwnusbaum @car-roll 🙏

[dwnusbaum]

@Casz FYI, I filed jenkins-infra/update-center2#305 to suspend distribution of durable-task 1.31 due to some issues on various platforms from a separate change, so we don't want to merge/release this with a dependency on 1.31. We're still trying to decide what to do with that issue, we might end up releasing 1.32 that reverts/disables the problematic change and then we could update to that here, or we might try to fix the issues with jenkinsci/durable-task-plugin#114 and then release 1.32.

[jetersen]

😭

[car-roll]

so 1.32 has been released and #123 has the 1.32 change as well as a changelog that covers this PR. Since ci.jenkins.io is down, I don't know if you just want to run your tests locally with 1.32 to make sure everything is okay. Would that be good enough to merge this in @dwnusbaum ?

[jetersen]

Here is my basic test that demonstrate it works:

Pipeline:

node {
    pwsh 'Write-Host "Hello from $($PSVersionTable.PSVersion) $($PSVersionTable.PSEdition)"'
    powershell 'Write-Host "Hello from $($PSVersionTable.PSVersion) $($PSVersionTable.PSEdition)"'
}

Run:

Started by user unknown or anonymous
Running in Durability level: MAX_SURVIVABILITY
[Pipeline] Start of Pipeline
[Pipeline] node
Running on Jenkins in C:\code\workflow-durable-task-step-plugin\work\workspace\test
[Pipeline] {
[Pipeline] pwsh
Hello from 6.2.3 Core
[Pipeline] powershell
Hello from 5.1.19008.1 Desktop
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS

[jetersen]

I can add a test case @car-roll if you want :)

[jetersen]

@slide hmm the new Windows 2019 servers do they have powershell core or do I have to put it in docker?

[slide]

They do not have powershell core right now.

[jetersen]

@slide I don't see any docs for buildPlugin on how to use Windows Server 2019 for using Windows Docker 😅

[slide]

@Casz good question, this is the first time this has come up so far. We may need to enhance

[car-roll]

So we are not at 1.33 for durable-task. That should resolve the issues that were introduced in 1.31. So far no other complaints, so you can go ahead and update this dependency again (sorry 😞 ). I think maybe another day with no other major issues popping up, we can merge and release

[jetersen]

Would appreciate a release 🙏

[car-roll]

sorry for all the delays @Casz 😢 Took some time to make sure durable-task 1.33 didn't introduce any more problems. I'm merging this now.

[jetersen]

No, thank you! Sorry for being so pushy 😓