-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the WorkflowRun/index.jelly
file
#364
Conversation
What is that failed to determine thing? |
Marking as draft since this cannot be merged as is—only if and when the core PR is merged, and the baseline version here is updated accordingly. |
Something about changesets. jenkinsci/jenkins#8110 (comment) |
Set the |
Does this still need work to adapt to jenkinsci/jenkins@f405797? |
@janfaracik can you please check whether this is still working as expected, and if so, mark it ready for review? |
Tried it out with a basic pipeline, looks to be working fine. Only one issue has been raised for the core PR and that's https://issues.jenkins.io/browse/JENKINS-73168 |
OK, just mark ready for review whenever you think it is safe to merge. |
(Requesting review from reviewers of the core PR, since they probably more context for this than I.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, I tested this at the time
Relates to jenkinsci/jenkins#8110
This PR removes the
WorkflowRun/index.jelly
file as if #8110 is merged, it'd be possible to rely on theRun/index.jelly
file from Jenkins instead.It would be preferable to have plugins extend pages rather than to reimplement them to make changes in core easier and more consistent. This will be important with upcoming works on the Jenkins user experience, such as introducing app bars, new widgets and adjusting the sidebar.
If there's anything I've missed do let me know.
Before
After
Testing done
Submitter checklist