Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-27299] WorkflowJob.disabled #46

Merged
merged 16 commits into from
May 12, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented May 3, 2017

Unlike #47 this would work on existing baselines. Supersedes #23.

@reviewbybees

@jglick
Copy link
Member Author

jglick commented May 5, 2017

mvn -f ../jenkins -DskipTests clean install
mvn clean install
mvn -Djenkins.version=2.59-SNAPSHOT surefire:test

passes, meaning that an update of core prior to a plugin update to a version including the planned simplifications will not cause regressions.

@jglick
Copy link
Member Author

jglick commented May 5, 2017

Build failures are timeouts: INFRA-1176

jglick added a commit to jglick/workflow-job-plugin that referenced this pull request May 5, 2017
@jglick jglick requested a review from abayer May 5, 2017 19:28
@ghost
Copy link

ghost commented May 5, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick closed this May 9, 2017
@jglick jglick reopened this May 9, 2017
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the quick review 🐝

@jglick jglick closed this May 12, 2017
@jglick jglick reopened this May 12, 2017
@jglick
Copy link
Member Author

jglick commented May 12, 2017

@reviewbybees done

@jglick jglick closed this May 12, 2017
@jglick jglick reopened this May 12, 2017
@jglick jglick merged commit d1874be into jenkinsci:master May 12, 2017
@jglick jglick deleted the WorkflowJob.disabled-JENKINS-27299 branch May 12, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants