Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of Prototype #221

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Remove usages of Prototype #221

merged 1 commit into from
Jul 25, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jul 20, 2023

To test this I ran the test suite against a version of Jenkins with Prototype removed. Before this PR the test suite failed; after this PR, the test suite passed.

@basil basil mentioned this pull request Jul 25, 2023
Merged
14 tasks
@basil basil requested a review from a team July 25, 2023 19:09
jglick
jglick approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in hpi:run by configuring the Jenkins root URL, installing pipeline-input-step, creating a Pipeline

input 'OK?'

and running it, then clicking the Proceed prompt from the standard log view.

@jglick jglick merged commit 5a383bd into jenkinsci:master Jul 25, 2023
13 checks passed
@basil basil deleted the remove-prototype branch July 26, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basil @jglick @MarkEWaite