Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73421] Expose getExternalizableId() in RunWrapper API #268

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

stuartrowe
Copy link
Contributor

@stuartrowe stuartrowe commented Jul 8, 2024

Implementation for https://issues.jenkins.io/browse/JENKINS-73421.

Expose getExteralizableId() in RunWrapper API. Returns the value of the existing externalizableId member which is assigned the externalizableId of the underlying build object when the RunWrapper is constructed.

Testing done

Added new unit test in RunWrapperTest.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@stuartrowe
Copy link
Contributor Author

@jglick are you able to review this please?

@stuartrowe stuartrowe marked this pull request as draft July 8, 2024 22:31
@stuartrowe stuartrowe marked this pull request as ready for review July 8, 2024 22:33
jglick

This comment was marked as resolved.

stuartrowe and others added 2 commits July 9, 2024 12:07
Make the RunWrapperTest#externalizableId) test more robust and exercise the property getter.

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@stuartrowe stuartrowe requested a review from jglick July 9, 2024 19:12
@jglick jglick merged commit c71c40c into jenkinsci:master Jul 10, 2024
14 checks passed
@r00t-
Copy link

r00t- commented Jul 10, 2024

great, thanks!
(this resulted from my comment at jenkinsci/pipeline-build-step-plugin#106 (comment) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants