Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate need for reflection when calling getChangeSets #41

Merged
merged 2 commits into from
Aug 16, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 15, 2017

@ghost
Copy link

ghost commented Aug 15, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@abayer abayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for build result. I'm not a big fan of bumping the core dependency that high, but eh, that just means that if other changes are going to go in workflow-support in the next few months, they probably need to go on a 2.14.x branch too.

@jglick
Copy link
Member Author

jglick commented Aug 16, 2017

Build is clean.

Regarding the core dep, well, you could

  • merge, and create a backports branch
  • put this PR on hold
  • start a development branch (and I guess origin PR) for newer baseline and merge this into it

@abayer
Copy link
Member

abayer commented Aug 16, 2017

2.14.x branch cut, gonna merge this.

@recampbell
Copy link
Member

@reviewbybees done

@abayer abayer merged commit 01f9538 into jenkinsci:master Aug 16, 2017
@jglick jglick deleted the getChangeSets branch August 26, 2017 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants