Update POM for next release #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
Jan 3, 2019
| <configuration> | ||
| <rules> | ||
| <enforceBytecodeVersion> | ||
| <excludes combine.children="append"> |
There was a problem hiding this comment.
No longer necessary after jenkinsci/plugin-pom#136 (confirmed that on parent pom 3.28 the config is necessary, but on 3.29+ it is not).
| <changelist>-SNAPSHOT</changelist> | ||
| <jenkins.version>2.121.1</jenkins.version> | ||
| <java.level>8</java.level> | ||
| <plugin.minimumJavaVersion>11</plugin.minimumJavaVersion> |
There was a problem hiding this comment.
The code will work fine on Java 8 as well, and we want to release it to everyone.
| @@ -32,7 +32,6 @@ | |||
| import org.jenkinsci.plugins.workflow.job.WorkflowRun; | |||
| import org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep; | |||
| import org.junit.ClassRule; | |||
| import org.junit.Ignore; | |||
There was a problem hiding this comment.
I should have removed the import in #86.
| @@ -42,7 +42,6 @@ | |||
| import org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep; | |||
| import static org.junit.Assert.*; | |||
| import org.junit.ClassRule; | |||
| import org.junit.Ignore; | |||
There was a problem hiding this comment.
Should have been removed in #86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates just to get things ready for the release (which will support Java 8 in addition to newer Java versions). Once this PR is merged, we should merge the
java11branch intomasterand release it.