Add class filter entry for TraceInformation$IncompleteObjectInfo #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning for this class came up recently in Evergreen error logs. I recall some discussion around this type (and one other, perhaps
TraceInformation$IndexInfo?) in the past, but can not find any record of such a discussion. The IncompleteObjectInfo class looks harmless from a serialization/deserialization security perspective.Maybe the reason we are seeing this now is that in some cases an error thrown as a result of the 2.x to 3.x upgrade uses this type in an error message, but other than that I think it could be used if the serialized file is corrupted or the implementations of serialization-related methods are incorrect (as in this reproduction). It doesn't seem valuable to me to try to reproduce the warning in a test here, but I would be happy to do so if reviewers think it would be useful.
I don't know if the warning really had any impact to end users, since as far as I can tell in my reproduction the only difference is that without the class filter entry, the exception is wrapped in
hudson.remoting.ProxyException, but with the entry the underlying exception type is exposed.Builds on #50.