Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of ISO Country Codes (Char and Num) to gapminder data objects #16

Closed
wants to merge 3 commits into from

Conversation

jrebane
Copy link

@jrebane jrebane commented Oct 21, 2016

Description

This commits changes the following:

  • Adds ISO 3166-1 alpha-3 and ISO 3166-1 numeric country codes as two additional variables for the gapminder and gapminder_unfiltered objects
  • Updates documentation (mostly) to reflect added variables

Motivation and Context

How Has This Been Tested?

  • Local tests have not been run yet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests pass

@jennybc
Copy link
Owner

jennybc commented Oct 31, 2017

Thanks! I took your code for getting these codes and reworked it in the poorly-named commit 700b427 and subsequent commits. I tried to bring this branch local and find a way to merge it, but there was too much conflict. I didn't want to bring the country codes into the main data frame. I've credited you in NEWS.

Thanks again.

@jennybc jennybc closed this Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants