Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0184-WebUI-Fix-EM8LockedChannelBehaviour #2599

Merged

Conversation

Baxxy13
Copy link
Contributor

@Baxxy13 Baxxy13 commented Jan 9, 2024

Description

The input channel behaviour of HM-MOD-EM8 is always locked, even if there is no program or link.
This patch fixes the always locked channel behaviour for HM-MOD-EM8.

Related Issue

HM-MOD-EM-8 8kanal Sender als TFK konfigurieren
8Kanal Sensor HM-MOD-EM-8 lässt sich nicht einstellen...

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

It could have an impact on other devices with configurable inputs.
But I can't test this because I don't have any such devices.

Verification Process

I applied the patch on a test system and didn't notice any problems at first.
Code-Support by: @jp112sdl

Release Notes

Patch that fixes the always locked channel behaviour for HM-MOD-EM8.

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

- fixes the locked channel behaviour for HM-MOD-EM8
@Baxxy13
Copy link
Contributor Author

Baxxy13 commented Jan 9, 2024

Actually channel behaviour is locked even if there are no programs or links.
RM_HM-MOD-EM8_Channel_Settings_locked

With the patch channel behaviour is unlocked if there are no programs or links.
RM_HM-MOD-EM8_Channel_Settings_unlocked

@jp112sdl
Copy link
Contributor

@Baxxy13 Danke, dass du die Arbeit für den PR erledigt hast. 👍

@jens-maus jens-maus added 🏷️ WebUI This refs the WebUI component 🐛 bug-report Something isn't working labels Jan 10, 2024
@jens-maus jens-maus added this to the next release milestone Jan 10, 2024
@jens-maus jens-maus merged commit 10eb206 into jens-maus:master Jan 10, 2024
6 checks passed
@Baxxy13 Baxxy13 deleted the 0184-WebUI-Fix-EM8LockedChannelBehaviour branch January 29, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants