Protection against XSS by CSP & mask ReGaHss Servername #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. the setenv.set-response-header part will overwrite the possibly provided ReGaHss Server name on Lighttpd controlled ports The HTTP response header will not longer contain ```Server: ise GmbH HTTP-Server v2.0``` --> it becomes ```Server: Server``` If a system is available on open port 80 by portforwarding, it is not longer identifiable by this special server name Currently there are 8303 open HomeMatic systems listed: https://www.shodan.io/search?query=ise+GmbH+HTTP-Server+v2.0 It's (a little bit) harder for the attacker to find a HomeMatic system, if the Server HTTP header is obfuscated. 2. The CSP setting protects against XSS attacks. It needs to allow remote host ```*.homematic.com``` to be able to load version check java script from http://ccu3-update.homematic.com/firmware/download?cmd=js_check_version&........ You may adjust the host name for RaspberryMatic update check, too.
|
As your PR is for RaspverryMatic please provide the correct CSP setting and please provide references to appropriate documentation explaining the theory behind your changes in detail. |
|
I don't know the update check URLs used in RaspverryMatic, as the maintainer you should adapt them. Which theory do you mean? The configuration usage or the help of response obfuscation? |
jens-maus
added
💡 enhancement-ideas
jens-maus
added a commit
that referenced
this pull request
Apr 10, 2019
for newer firmware devices for RaspberryMatic. Also added "X-WebKit-CSP" response header to serve older webbrowsers as well. In addition, neither lighttpd nor ReGa will now output any "Server:" response header anymore to prevents detailed analyses on the web server type. This refs #597.
|
Thanks for your PR. After some checks I integrated it now and also enhanced it a bit. |
jens-maus
added a commit
that referenced
this pull request
Apr 10, 2019
the cross site image reference to paypalobjects.com. This refs #597.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the setenv.set-response-header part will overwrite the possibly provided ReGaHss Server name on Lighttpd controlled ports
The HTTP response header will not longer contain
Server: ise GmbH HTTP-Server v2.0--> it becomesServer: ServerIf a system is available on open port 80 by portforwarding, it is not longer identifiable by this special server name
Currently there are 8303 open HomeMatic systems listed: https://www.shodan.io/search?query=ise+GmbH+HTTP-Server+v2.0
It's (a little bit) harder for the attacker to find a HomeMatic system, if the Server HTTP header is obfuscated.
The CSP setting protects against XSS attacks. It needs to allow remote host
*.homematic.comto be able to load version check java script from http://ccu3-update.homematic.com/firmware/download?cmd=js_check_version&........You may adjust the host name for RaspberryMatic update check, too.