De-lint PROPKA #33
Merged
De-lint PROPKA #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only implemented fixes that do not change functonality. Avoided changing numbers of arguments, numbers of attribute, variable/function names, etc.
Other changes are a result of Atom use in other files.
Do we drop 3.0 support? I vote "yes" but will leave that for the next commit.
orbeckst
reviewed
May 22, 2020
Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a long pull request (or perhaps multiple requests) to bring PROPKA 3.1 close to PEP8 standards. Use of standards should make it easier to maintain community development.
@orbeckst and @speleo3 - can you take a look?