Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespaces #30

Open
jenstornell opened this issue Jun 24, 2019 · 2 comments
Open

Add namespaces #30

jenstornell opened this issue Jun 24, 2019 · 2 comments

Comments

@jenstornell
Copy link
Owner

I would like to contribute to the project, as soon as I saw it I liked it, I was looking for a simple way to compress the html code and I found this. I have knowledge of composer, I agree with @Modicrumb, you have to use namespaces. I could do a pull-request with this change.

Originally posted by @EdixonAlberto in #17 (comment)
@jenstornell jenstornell mentioned this issue Jun 24, 2019
Open
@jenstornell
Copy link
Owner Author

@EdixonAlberto You can contribute with pull request if you like. Small pull requests have a better chance at being merged faster. Thanks!

@EdixonAlberto EdixonAlberto mentioned this issue Jun 24, 2019
Open
@EdixonAlberto
Copy link
Contributor

I'm going to make an important contribution to the library to use in the future namespace. But before they should make the following changes:

EdixonAlberto added a commit to EdixonAlberto/tiny-html-minifier that referenced this issue Jun 25, 2019
@EdixonAlberto
add namespaces jenstornell#30
5bea148 
- changing class autoloader to PSR-4 in composer.
- adding comment with namespace in each class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jenstornell @EdixonAlberto