-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18 and bug fixes #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how concise everything is now. Great work, just general questions. Approve for merge
The Great Escape
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's allow duplicate notifications and see how it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notifications work fine as expected, I really like how multiple duplicate notifications are displayed now.
@jeongm-in It has its limits, too. For example, It shows at most three notifications at a time, so the remaining notifications are |
How to test i18n
1. Follow the instruction from https://developer.chrome.com/extensions/i18n#win-shortcut, copy and pasted below:
To create and use a shortcut that launches Google Chrome with a particular locale:
1 Make a copy of the Google Chrome shortcut that's already on your desktop.
2. Rename the new shortcut to match the new locale.
3. Change the shortcut's properties so that the Target field specifies the --lang and --user-data-dir flags. The target should look something like this:
path_to_chrome.exe --lang=locale --user-data-dir=c:\locale_profile_dir
For me it looks like this: "C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --lang=ko --user-data-dir=c:\chrome-profile-ko
4. Launch Google Chrome by double-clicking the shortcut.
For example, to create a shortcut that launches Google Chrome in Spanish (es), you might create a shortcut named chrome-es that has the following target:
path_to_chrome.exe --lang=es --user-data-dir=c:\chrome-profile-es
You can create as many shortcuts as you like, making it easy to test in multiple languages. For example:
path_to_chrome.exe --lang=en --user-data-dir=c:\chrome-profile-en
path_to_chrome.exe --lang=en_GB --user-data-dir=c:\chrome-profile-en_GB
path_to_chrome.exe --lang=ko --user-data-dir=c:\chrome-profile-ko
2. Open the shortcut with a different locale and log in with your Google account.
3. Go to chrome://extensions/, enable Developer Mode... You know everything from here.
Other issues
messages.json
files, you'll know what to do.