Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18 and bug fixes #57

Merged
merged 9 commits into from
Jul 7, 2019
Merged

I18 and bug fixes #57

merged 9 commits into from
Jul 7, 2019

Conversation

Bartleby2718
Copy link
Collaborator

How to test i18n

1. Follow the instruction from https://developer.chrome.com/extensions/i18n#win-shortcut, copy and pasted below:

To create and use a shortcut that launches Google Chrome with a particular locale:

1 Make a copy of the Google Chrome shortcut that's already on your desktop.
2. Rename the new shortcut to match the new locale.
3. Change the shortcut's properties so that the Target field specifies the --lang and --user-data-dir flags. The target should look something like this:
path_to_chrome.exe --lang=locale --user-data-dir=c:\locale_profile_dir
For me it looks like this: "C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --lang=ko --user-data-dir=c:\chrome-profile-ko
4. Launch Google Chrome by double-clicking the shortcut.
For example, to create a shortcut that launches Google Chrome in Spanish (es), you might create a shortcut named chrome-es that has the following target:
path_to_chrome.exe --lang=es --user-data-dir=c:\chrome-profile-es
You can create as many shortcuts as you like, making it easy to test in multiple languages. For example:
path_to_chrome.exe --lang=en --user-data-dir=c:\chrome-profile-en
path_to_chrome.exe --lang=en_GB --user-data-dir=c:\chrome-profile-en_GB
path_to_chrome.exe --lang=ko --user-data-dir=c:\chrome-profile-ko

2. Open the shortcut with a different locale and log in with your Google account.

3. Go to chrome://extensions/, enable Developer Mode... You know everything from here.

Other issues

  • Contributing translations is easy. If you see the directory structure and the messages.json files, you'll know what to do.

@Bartleby2718 Bartleby2718 added bug Something isn't working enhancement New feature or request refactoring Altering the internal--but not external--behavior labels Jul 6, 2019
@Bartleby2718 Bartleby2718 added this to the Minimum Viable Product milestone Jul 6, 2019
@Bartleby2718 Bartleby2718 self-assigned this Jul 6, 2019
@jeongm-in jeongm-in marked this pull request as ready for review July 6, 2019 13:53
Copy link
Owner

@jeongm-in jeongm-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how concise everything is now. Great work, just general questions. Approve for merge

@jeongm-in jeongm-in self-requested a review July 6, 2019 16:08
Copy link
Owner

@jeongm-in jeongm-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's allow duplicate notifications and see how it is.

Copy link
Owner

@jeongm-in jeongm-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notifications work fine as expected, I really like how multiple duplicate notifications are displayed now.

@jeongm-in jeongm-in merged commit 41c6fbd into master Jul 7, 2019
@Bartleby2718
Copy link
Collaborator Author

@jeongm-in It has its limits, too. For example, It shows at most three notifications at a time, so the remaining notifications are queued and shown when the previous notifications are gone.

@Bartleby2718 Bartleby2718 deleted the i18-and-bug-fixes branch July 12, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactoring Altering the internal--but not external--behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants