Issue#1364: Added case rules for subprogram instantiation declarations #1371
Conversation
…rks at the end of procedure declarations.
…ted procedure_009, in favour of subprogram_kind rules.
…program_kind_501.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1371 +/- ##
==========================================
+ Coverage 94.51% 94.53% +0.02%
==========================================
Files 1723 1737 +14
Lines 30953 31041 +88
Branches 3482 3482
==========================================
+ Hits 29255 29345 +90
+ Misses 1275 1274 -1
+ Partials 423 422 -1 ☔ View full report in Codecov by Sentry. |
JHertz5
changed the title
There was a problem hiding this comment.
Evening @JHertz5 ,
The PR looks good. I agree with creating the subprogram_kind rules and deprecating function_014 and procedure_505.
I just had a couple of questions on the rule documentation.
Thanks again,
--Jeremy
docs/subprogram_kind_rules.rst
Outdated
|
|
||
| end PROCEDURE parity; | ||
|
|
||
| PROCEDURE my_proc is new my_generic_proc |
There was a problem hiding this comment.
Should PROCEDURE be changed to lower case on lines 27 and 29?
There was a problem hiding this comment.
You are absolutely right, thanks for catching that!
docs/subprogram_kind_rules.rst
Outdated
|
|
||
| end FUNCTION parity; | ||
|
|
||
| FUNCTION my_func is new my_generic_func |
There was a problem hiding this comment.
Should FUNCTION be changed to lowercase on lines 52 and 54?
There was a problem hiding this comment.
You are absolutely right, thanks for catching that!
Thanks for catching those mistakes! I've made corrections and the PR is ready for you to look at again. Thanks, |
Resolves #1364.
Note that, as part of this work, I discovered that function_014 and procedure_505 are programmed to act on all instances of their respective subprogram kind, which meant that, contrary to their description, they were acting on subprogram instantiations. I've deprecated those rules and replaced them with
subprogram_kindrules. If this approach is not preferred, I am happy to revert/modify those changes.