Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open full with SnapPoint #150

Closed
WesleyFaveri opened this issue Mar 18, 2020 · 5 comments
Closed

Open full with SnapPoint #150

WesleyFaveri opened this issue Mar 18, 2020 · 5 comments
Labels
🚀 New feature New feature or request

Comments

@WesleyFaveri
Copy link
Contributor

Hello, theres any way to open full modal with snapPoint prop? I want open full modal when a button is pressed on snapPoint state
@jeremybarbet
Copy link
Owner

Hi,

So you want to use a prop like open() but only to pass from the first snapPoint to full height? If so, it's not possible right now, but you could create a PR to implement this!

@jeremybarbet jeremybarbet added the 🚀 New feature New feature or request label Mar 19, 2020
@WesleyFaveri
Copy link
Contributor Author

Yes, that's i'm trying to do. i'll try save a time and work on a PR

WesleyFaveri added a commit to WesleyFaveri/react-native-modalize that referenced this issue Mar 19, 2020
@WesleyFaveri
feat: add prop to open full with snap state jeremybarbet#150
8f395b6
@WesleyFaveri
Copy link
Contributor Author

#153

@WesleyFaveri
Copy link
Contributor Author

WesleyFaveri commented Mar 19, 2020 •
edited
Loading

Added a prop to identify if need open full or keep default open. I got a issue with open modal with alwaysOpen prop and i cant identify what happen to reproduce that, try modal.current.open() with alwaysOpen prop

jeremybarbet pushed a commit that referenced this issue Mar 20, 2020
@WesleyFaveri
feat: add prop to open full with snap state #150 (#153)
dfd56fb
@jeremybarbet
Copy link
Owner

jeremybarbet commented Mar 20, 2020 •
edited
Loading

Should be fixed now, I will release a new rc soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 New feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremybarbet @WesleyFaveri