Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix- modal jumping height #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jlsajfj
Copy link

@jlsajfj jlsajfj commented May 17, 2024

DragY is being reset somewhere- causes modal to jump around. Workaround is to set it again at the start of handleAnimateOpen

#498 (comment)

@iancartis
Copy link

Hello <3,
We really need this to be fixed as we are using it on a production application.
Do we have any estimation on when this is going to be merged?

Thanks for all the amazing work!

@MilanMalovic
Copy link

Hi @jeremybarbet, w are currently using this functionality in a production, and resolving this issue would greatly improve the user experience. The workaround provided is helpful, but we would appreciate it if the fix could be officially integrated into the codebase.
Could you please provide an estimate on when the fix might be merged? We are eager to implement it as soon as possible to ensure smooth functionality in our app.

@Andrija00
Copy link

@jeremybarbet Can you merge this one please?

@jlsajfj
Copy link
Author

jlsajfj commented Dec 5, 2024

Anyone who needs this, just change your package.json to look like the following:

"react-native-modalize": "git+https://github.com/jlsajfj/react-native-modalize.git",

This should replace the version number.

@amerllica
Copy link

I just got the index change by directly modifying the node_modules and running npx patch-package react-native-modalize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants