Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep a TypeScript definition file for Shifty. #68

Closed
ghost opened this issue Mar 9, 2015 · 5 comments · Fixed by #135
Closed

Keep a TypeScript definition file for Shifty. #68

ghost opened this issue Mar 9, 2015 · 5 comments · Fixed by #135

Comments

@ghost
Copy link

ghost commented Mar 9, 2015

While I keep using Javascript for lower-level stuff in the webview, to squeeze out some more horsepower, where applicable, I also use TypeScript as my main programming language for doing the more structured code my phonegap/web/webview-related apps.
That's why I would like to keep an up-to-date TypeScript definition file for Shifty.
Anybody else interested?
@jeremyckahn
Copy link
Owner

I'd be fine with adding a TypeScript definition to the project. I haven't used TypeScript, so I can't do much to help the effort, but I will happily accept it if you make a Pull Request!

@ghost
Copy link
Author

ghost commented Mar 27, 2015

Maybe, once finished, this should be kept on definitelytyped.org repository where all the other libraries' definition files are stored.

@ghost ghost closed this as completed Mar 27, 2015
@jeremyckahn
Copy link
Owner

Let's keep this open. Though I don't have any plans to create a TypeScript definition for Shifty myself, anyone else is free to do so. I consider issues open until it they are determined to be addressed, not useful, or unaddressable.

@jeremyckahn jeremyckahn reopened this Mar 28, 2015
@jeremyckahn
Copy link
Owner

Closing this due to inactivity. Happy to reopen this to accept a PR, though!

@jeremyckahn jeremyckahn reopened this Nov 15, 2021
@jeremyckahn jeremyckahn mentioned this issue Nov 15, 2021
Merged
@jeremyckahn
Copy link
Owner

It looks like there has been some work started in relation to this in 4ian/GDevelop#3218: https://github.com/4ian/GDevelop/pull/3218/files#r749378411

@arthuro555 arthuro555 mentioned this issue Nov 19, 2021
Merged
jeremyckahn added a commit that referenced this issue Nov 21, 2021
@jeremyckahn
[#68] Fix lint errors
94ca52b
jeremyckahn added a commit that referenced this issue Nov 22, 2021
@jeremyckahn
[#68] Remove token import
62b0c6c
jeremyckahn added a commit that referenced this issue Nov 22, 2021
@jeremyckahn
[#68] Fix doc:view script
2090310
jeremyckahn added a commit that referenced this issue Nov 22, 2021
@jeremyckahn
[#68] Fix doc:view script
627394d
jeremyckahn added a commit that referenced this issue Dec 8, 2021
@arthuro555 @jeremyckahn
[closes #68] Add typescript definitions generation (#135)
c43ddbf 
* Add typescript definitions generation

* `ts`: Fix lint errors

* Fix doc:view script

* Add type generation to ci script

Co-authored-by: Jeremy Kahn <jeremyckahn@gmail.com>
jeremyckahn added a commit that referenced this issue Dec 9, 2021
@arthuro555 @jeremyckahn
[closes #68] Add typescript definitions generation (#135)
bb841b4 
* Add typescript definitions generation

* `ts`: Fix lint errors

* Fix doc:view script

* Add type generation to ci script

Co-authored-by: Jeremy Kahn <jeremyckahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add typescript definitions generation arthuro555/shifty
1 participant
@jeremyckahn