User Provided S3 Config

[chrisowebb]

Allow user to provide configuration for S3 on api init

User may want to change the config of the client for s3. One example of this is during local dev, to change endpoint etc.

I think the only way to currently do this, is to import the client from lambda-api/lib/s3-service.js and override it?

I think it might be a nicer user experience to be able to provide the config on api init. 😄

[naorpeled]

Hey @chrisowebb

Thanks for opening this PR, you're awesome! Great feature!

I'm currently on vacation until Tuesday+-

Will be able to check this more thoroughly then.
In the meantime, could you please add some tests? that'd be much appreciated❤️

[chrisowebb]

Hey @chrisowebb

Thanks for opening this PR, you're awesome! Great feature!

I'm currently on vacation until Tuesday+-

Will be able to check this more thoroughly then. In the meantime, could you please add some tests? that'd be much appreciated❤️

hey, @naorpeled thanks for the response. Have you had a chance to look at this yet ? 😄

[naorpeled]

Hey @chrisowebb

Thanks for opening this PR, you're awesome! Great feature!

I'm currently on vacation until Tuesday+-

Will be able to check this more thoroughly then. In the meantime, could you please add some tests? that'd be much appreciated❤️

hey, @naorpeled thanks for the response. Have you had a chance to look at this yet ? 😄

My plan is to try it out today 😎
Don't worry, didn't forget

[naorpeled]

Imo, in order to not making a breaking change,
we should not remove the ``exports.client = new S3Client()``` above.

Wdyt?

Also, regarding naming of setClient,
maybe we should rename to setConfig or overrideConfig because we're not passing a client, wdyt?

[chrisowebb]

Good points, totally agree. I have made updates to reflect this 😄

[naorpeled]

LGTM 😎

I wonder whether we can implement setConfig without creating a new instance of the client.
Honestly it's probably not super crucial but just a thought.

Anyways, thanks for this, you rock!

[naorpeled]

Will merge and release this tomorrow 🙏