Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple targets #13

Merged
merged 4 commits into from
Jan 22, 2023
Merged

Conversation

MickVanDuijn
Copy link
Contributor

In an organization with multiple micro-services, each with multiple lambdas, the CloudWatch Rule limit of 100 is easily reached. With these additions, there can be a single warmer per micro-service, invoking all applicable lambdas with the desired concurrency.

@coveralls
Copy link

coveralls commented Jul 16, 2019

Pull Request Test Coverage Report for Build 20

  • 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 17: 0.0%
Covered Lines: 42
Relevant Lines: 42

💛 - Coveralls

@rictorres
Copy link

awesome!

@MickVanDuijn
Copy link
Contributor Author

MickVanDuijn commented Jul 17, 2019

Note: a lot of the changes are due to eslint, so I could change it back if desired!

@rictorres
Copy link

rictorres commented Sep 5, 2022

@jeremydaly any chance you'd like to land this change? 🙏

@naorpeled naorpeled self-requested a review January 13, 2023 19:12
@naorpeled naorpeled self-assigned this Jan 13, 2023
@naorpeled naorpeled added the enhancement New feature or request label Jan 13, 2023
@naorpeled
Copy link
Collaborator

I'm planning on reviewing this a bit later and then I'll work on a PR that adds type definitions to this, afterwards hopefully release this 🙏

@naorpeled naorpeled changed the title Feature: multiple targets feat: support multiple targets Jan 22, 2023
@naorpeled naorpeled merged commit fb055a8 into jeremydaly:master Jan 22, 2023
Copy link
Collaborator

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants