handle multiple non warming events #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larte
force-pushed
the
fix/multiple-valid-events
branch
from
6133039
to
edd7736
Compare
naorpeled
reviewed
Mar 4, 2023
naorpeled
approved these changes
Mar 4, 2023
This was referenced Nov 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, implementing a lambda handler for an Appsync batch resolver means handling a list of Appsync resolver events as input for the lambda handler.
Because of the multiple targets feature handling a array of events
lambda-warmer/index.js
Line 139 in 60f2fa2
await warmer(events))always resolves to true.The suggested change makes warmer return true if any event is a warmer event. This should cover most of the cases, since having both warmer events and valid ones in single invocation should not happen.