Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly working cargo features #91

Closed
wants to merge 1 commit into from
Closed

Properly working cargo features #91

wants to merge 1 commit into from

Conversation

TobiasBales
Copy link
Contributor

I somehow misread the cargo features documentation in what exactly exposes to #cfg
This now properly compiles and finishes #66

@jeremyletang
Copy link
Owner

This seems to break the travis build, the makefile is not valid.

It make me think that it may be a good time to switch travis build to cargo, and keep autoconf + make only to build gtk_glue. What do you think about this @TobiasRaeder ?

@TobiasBales
Copy link
Contributor Author

Sounds like a good idea.
Currently trying to fix the make build for now though.
Will let you know if I give up ;)

@TobiasBales
Copy link
Contributor Author

Okay, maybe it is the right move.
According to cargo build -v it passes --cfg feature="GTK_3_12" to rustc but for me that fails in the rust cfgspec when calling in a shell.

I'd be in favor of just using make to generate the glue library only, cargo for the rest

@TobiasBales
Copy link
Contributor Author

Any updates on the travis build update?

@jeremyletang
Copy link
Owner

This seems always broken: see here.
Do you think you can fix it ? can we pass the feature by parameter to cargo build ?
You should know that Travis only support gtk 3.6.

@TobiasBales
Copy link
Contributor Author

I thought you wanted to just use make for glue code compilation.
But I will see if I can just fix the makefile

@jeremyletang
Copy link
Owner

hey ! #99 seems to build, so i'll merge it. I open an issue about porting travis build to cargo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants