Upgrade ktlint -> 0.42.0 #215
Conversation
Fixes a nasty performance bug: pinterest/ktlint#1135
|
Wow. Didn't expect that to break the world! |
|
Ugh... ktlint has bumped the kotlin version to 1.5.20. So can't upgrade without gradle upgrading their embedded kotlin version. gradle depending on a specific version of kotlin, and being so slow to update, is a grade a pain. Mind you, ktlint going up a major version of kotlin in a release that fixes a major performance regression is also less than kind. |
ktlint 0.42.0 depends on 1.5.10. Gradle embeds kotlin 1.4, which prevents plugins depending on 1.5.x. By fixing the kotlin version to 1.4.x the build passes - looks like ktlint doesn't use any 1.5 exclusive features?
|
Build passes if I fix the kotlin version. |
|
Nope, doesn't then work as a plugin. Fail. |
|
Hi @Mahoney thanks for the assist. I've been tracking the progress of 0.42.0 and will upgrade soon. Right now it looks like it's got some indent regressions, so I'm waiting in anticipation of a 0.42.1 soon which might address them. Unless something new has gone sideways with gradle (such as it did before 6.8) it should be possible to take the 1.5.x kotlin upgrade even if have to declare the newest version of kotlinter will require kotlin 1.5.x. This happens periodically because of the dependency on the internal kotlin compiler. BTW, I do not believe pinterest/ktlint#1135 effects kotlinter. We integrate directly with the |
|
OK, not scientific but having installed the pre push commit hook I had had a couple of times when it felt very slow, saw the performance regression on ktlint and assumed that was it. It might be that gradle keeps having to spin up a new daemon because of a memory leak somewhere in my build. |
Fixes a nasty performance bug: pinterest/ktlint#1135