Fix Signing of SAML2 Requests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pysaml2 requires to set `sign=True` during `prepare_for_authenticate`. We also move `relay_state` to `prepare_for_authenticate` to make sure the generated signatures are valid
|
@jeremyschulman is there a way to help you in confirming this PR? I'd be glad to provide assistance :) |
|
@prauscher - my apologies. I'll merge this and publish a new package to PyPi today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pysaml2 requires to set
sign=Trueduringprepare_for_authenticate. We also moverelay_statetoprepare_for_authenticateto make sure the generated signatures are valid