fixed issue

jeremytammik · Jan 6, 2017 · 7cab26b · 7cab26b
1 parent 6f8b413
commit 7cab26b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/CS/AssemblyInfo.cs b/CS/AssemblyInfo.cs
@@ -110,7 +110,8 @@
 // 2016-12-20 - 2017.0.0.7 - merged pull request #18 by @Andrey-Bushman to use NuGet Revit API package
 // 2016-12-20 - 2017.0.0.8 - added version number to Hello World message box
 // 2017-01-03 - 2017.0.0.9 - incremented copyright year
-// 2017-01-06 - 2017.0.0.10 - merged pull from luftbanana supporting close-with-ESC to all forms by assigning the cancel button
+// 2017-01-06 - 2017.0.0.10 - merged pull #20 from @luftbanana supporting close-with-ESC to all forms by assigning the cancel button
+// 2017-01-06 - 2017.0.0.11 - fixed issue #19 raised by LeeJaeYoung spot dimension position and text position error
 //
-[assembly: AssemblyVersion( "2017.0.0.10" )]
-[assembly: AssemblyFileVersion( "2017.0.0.10" )]
+[assembly: AssemblyVersion( "2017.0.0.11" )]
+[assembly: AssemblyFileVersion( "2017.0.0.11" )]
diff --git a/CS/Snoop/CollectorExts/CollectorExtElement.cs b/CS/Snoop/CollectorExts/CollectorExtElement.cs
@@ -2209,23 +2209,35 @@ private void Stream( ArrayList data, Dimension dim )
           data.Add( new Snoop.Data.Exception( "Label", ex ) );
         }
       }
+
+      SpotDimension spotDim = dim as SpotDimension;
+
       data.Add( new Snoop.Data.Int( "Number of segments", dim.NumberOfSegments ) );
-      data.Add( new Snoop.Data.Xyz( "Leader End Position", dim.LeaderEndPosition ) );
+      if( null == spotDim )
+      {
+        // issue #19: 2017.0 crash on spot elevation
+        data.Add( new Snoop.Data.Xyz( "Leader End Position", dim.LeaderEndPosition ) );
+      }
       data.Add( new Snoop.Data.Xyz( "Origin", dim.Origin ) );
       data.Add( new Snoop.Data.String( "Prefix", dim.Prefix ) );
       data.Add( new Snoop.Data.String( "Suffix", dim.Suffix ) );
       data.Add( new Snoop.Data.Enumerable( "Segments", dim.Segments ) );
-      data.Add( new Snoop.Data.Xyz( "Text Position", dim.TextPosition ) );
+      if( null == spotDim )
+      {
+        // issue #19: 2017.0 crash on spot elevation
+        data.Add( new Snoop.Data.Xyz( "Text Position", dim.TextPosition ) );
+      }
       if( dim.Value != null )
+      {
         data.Add( new Snoop.Data.Double( "Value", dim.Value.Value ) );
+      }
       data.Add( new Snoop.Data.String( "Value Override", dim.ValueOverride ) );
       data.Add( new Snoop.Data.String( "Value string", dim.ValueString ) );
       data.Add( new Snoop.Data.Enumerable( "References", dim.References, m_activeDoc ) );
       data.Add( new Snoop.Data.Object( "View", dim.View ) );
 
       // TBD: Name overridden but doesn't appear to have correct keywords
 
-      SpotDimension spotDim = dim as SpotDimension;
       if( spotDim != null )
       {
         Stream( data, spotDim );