Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user maximize form full screen #134

Merged
merged 7 commits into from
Mar 2, 2022
Merged

Allow user maximize form full screen #134

merged 7 commits into from
Mar 2, 2022

Conversation

chuongmep
Copy link
Contributor

@chuongmep chuongmep commented Mar 1, 2022

Summary of the Pull Request

What is this about:
This is a small update allow user can maximize form full screen, may be will useful if have a long string data or user need expand form to review.
Description:
Before :
image
After :
Revit_MkbkoOBqJW

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Nice3point
Copy link
Collaborator

@chuongmep Minimize button disabled?

@chuongmep
Copy link
Contributor Author

chuongmep commented Mar 2, 2022

@Nice3point yes, do you want turn on it ?

@Nice3point
Copy link
Collaborator

@chuongmep I think yes, otherwise why this button is needed)

@chuongmep
Copy link
Contributor Author

@Nice3point I added more support minimizeBox size,

@Nice3point
Copy link
Collaborator

Nice3point commented Mar 2, 2022

@chuongmep this is not exactly the behavior that should be) the window is not minimized, but reduced to the minimum size with a slight lag
изображение

@chuongmep
Copy link
Contributor Author

chuongmep commented Mar 2, 2022

Fixed, because still exist setting AutoScaleBaseSize for form
https://user-images.githubusercontent.com/31106432/156343205-2d20c8b9-8f46-4366-88be-5f0cd4bd2e1e.mp4

@Nice3point
Copy link
Collaborator

Nice3point commented Mar 2, 2022

@chuongmep nice!) there was a small visual problem, when the window size is reduced, the OK button is cut off. It's not critical, but can you fix it? I don't know WinForms and can't fix it myself. can bind its size to the size of the table
изображение

@chuongmep
Copy link
Contributor Author

@Nice3point, fixed, only need change some anchor of button.
MWwJY8qta9

@Nice3point
Copy link
Collaborator

Nice3point commented Mar 2, 2022

@chuongmep not enough minimum size for other window types)
изображение

@chuongmep
Copy link
Contributor Author

@Nice3point
Copy link
Collaborator

@chuongmep try resize

@Nice3point
Copy link
Collaborator

@chuongmep I think we need to do the same for all these windows
изображение

@chuongmep
Copy link
Contributor Author

@Nice3point
Copy link
Collaborator

Nice3point commented Mar 2, 2022

No problem ! @Nice3point https://user-images.githubusercontent.com/31106432/156390543-18aceba0-0a77-4906-9e33-9674a373f2d8.mp4

I meant to resize to a minimum) you need to leave the same part of the window visible as the main window

ParameterView, 0 size
изображение

MainWindow
изображение

@chuongmep
Copy link
Contributor Author

oh i see.Let me fix now, sorry for misunderstanding your point :D

@chuongmep
Copy link
Contributor Author

chuongmep commented Mar 2, 2022

@Nice3point fixed, include some other Window.

Rec.0008.mp4

@Nice3point
Copy link
Collaborator

@chuongmep awesome)

@Nice3point Nice3point merged commit c26d930 into jeremytammik:dev Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants