Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TableSectionData support #224

Merged

Conversation

SergeyNefyodov
Copy link
Contributor

Summary of the Pull Request

What is this about:

I added support for some methods of TableSectionData class. It contains a lot of code, so I desided to divide PR into parts, because I'm not sure that I write code in best way in all the methods. The main question is about methods like GetCellCategoryId, which has 2 signatures: only columns and columns with rows. I think that thr best way is to divide these methods into 2 Resolve methods, but I don't nkow how, because they have same names.

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Apr 29, 2024

Qodana for .NET

2 new problems were found

Inspection name Severity Problems
Invert 'if' statement to reduce nesting ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@SergeyNefyodov
Copy link
Contributor Author

I improved code style from first commit and add all the methods which can be added to this class

@Nice3point Nice3point merged commit 845527e into jeremytammik:dev Apr 30, 2024
1 of 3 checks passed
@SergeyNefyodov SergeyNefyodov deleted the dev-table-section-data-part1 branch May 18, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants