Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TableView support #231

Merged
merged 2 commits into from
May 7, 2024

Conversation

SergeyNefyodov
Copy link
Contributor

@SergeyNefyodov SergeyNefyodov commented May 6, 2024

Summary of the Pull Request

What is this about:

I added support for all the methods of TableView. In some places code is strange, because I need TableSectionData to get know count of rows and columns, but this data locates in inheritors of table view only.

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented May 6, 2024

Qodana for .NET

4 new problems were found

Inspection name Severity Problems
Convert 'if' statement into 'switch' ◽️ Notice 4

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Nice3point
Copy link
Collaborator

@SergeyNefyodov yeh, we can use casting. This is bad API implementation without base type common method. Better to use switch expression. Currently we have only 2 derived types
изображение

@Nice3point
Copy link
Collaborator

            if (tableView is not ViewSchedule && tableView is not PanelScheduleView)
                return ResolveSet.Append("This view is not a schedule view");

and for this reason we can drop this check

@Nice3point Nice3point merged commit fd89c17 into jeremytammik:dev May 7, 2024
1 of 2 checks passed
@SergeyNefyodov SergeyNefyodov deleted the dev-table-view-support branch May 18, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants