Dev macro manager #268
Merged
Dev macro manager #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-manager # Conflicts: # source/RevitLookup/Core/ComponentModel/DescriptorMap.cs # source/RevitLookup/Core/ComponentModel/Descriptors/DocumentDescriptor.cs
…-manager # Conflicts: # source/RevitLookup/Core/ComponentModel/Descriptors/ApplicationDescriptor.cs # source/RevitLookup/Core/ComponentModel/Descriptors/EnumerableDescriptor.cs
Nice3point
requested changes
Jul 18, 2024
| } | ||
|
|
||
| public void RegisterExtensions(IExtensionManager manager) | ||
| { | ||
| manager.Register("GetFormulaFunctions", _ => FormulaManager.GetFunctions()); | ||
| manager.Register("GetFormulaOperators", _ => FormulaManager.GetOperators()); | ||
| manager.Register(nameof(MacroManager.GetMacroManager), _ => Variants.Single(MacroManager.GetMacroManager(_application))); |
There was a problem hiding this comment.
u can remove Variants.Single for extensions
| nameof(MacroManager.GetDocumentMacroSecurityOptions) => ResolveDocumentMacroSecurityOptions, | ||
| #endif | ||
| nameof(MacroManager.GetApplicationMacroSecurityOptions) => ResolveApplicationMacroSecurityOptions, | ||
| nameof(IEnumerable.GetEnumerator) => ResolveGetEnumerator, |
There was a problem hiding this comment.
GetEnumerator should be automatically resolved, what problem does using it in a Resolve method solve?
There was a problem hiding this comment.
I had some problems with it but resolved it. We really don't need this, I removed
Nice3point
requested changes
Jul 18, 2024
| @@ -36,6 +37,7 @@ public EnumerableDescriptor(IEnumerable value) | |||
| IsEmpty = value switch | |||
| { | |||
| string => true, | |||
| MacroManager enumerable => enumerable.Count == 0, | |||
There was a problem hiding this comment.
Move it to the very bottom. In the top position you should insert frequently used types to increase the efficiency of resolving switching cases
Nice3point
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
I added support to MacroManager class (and also we can see MacroModule and Macro)
Description:
Quality Checklist