Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution changes for multi-release building #58

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Solution changes for multi-release building #58

merged 4 commits into from
Apr 14, 2020

Conversation

harrymattison
Copy link
Contributor

@harrymattison harrymattison commented Apr 13, 2020

Create a signed MSI installer using Advanced Installer
Modify the Visual Studio solution to use macro variables to ease the process of building for different Revit version. All you need to do now is create a new configuration and the output direction, DLL references, and other items will automatically update

@jeremytammik
Copy link
Owner

hi harry, thank you for the enhancement! did you grab the latest version for 2021 before adding them? i see in your solution file mentions VS 15 whereas mine states VS 14... will that cause a problem for other developers using older versions of VS than you do, such as me?

@jeremytammik
Copy link
Owner

sign.bat uses your specific signature files... is this if use to others? can it be switched off if not signing? if i merge your pull request, will i be able to build myself at all, without signing?

@jeremytammik
Copy link
Owner

this all looks rather harry-specific and i worry whether i will be able to work with it at all myself... same for others, of course...

Use Visual Studio 2015
Remove extraneous configurations
@harrymattison
Copy link
Contributor Author

harrymattison commented Apr 13, 2020 via email

@harrymattison
Copy link
Contributor Author

harrymattison commented Apr 13, 2020 via email

@harrymattison
Copy link
Contributor Author

harrymattison commented Apr 13, 2020 via email

@jeremytammik
Copy link
Owner

great, i'll take your word for it then. i noticed the REM and then forgot about it again. thank you very much for your contribution! integrating and testing next.

@jeremytammik jeremytammik merged commit 67395aa into jeremytammik:master Apr 14, 2020
jeremytammik added a commit that referenced this pull request Apr 14, 2020
@jeremytammik
Copy link
Owner

jeremytammik commented Apr 14, 2020

i integrated your changes, compiled, failed (no config defined), set the configuration to 2021, recompiled, and all works well. published as release https://github.com/jeremytammik/RevitLookup/releases/tag/2021.0.0.1. can you check that my steps described above did not overwrite anything crucial for the multi-platform config? maybe now variables have been replaced by constants somewhere? thank you!

@jeremytammik
Copy link
Owner

would you like to update the notes on the multi-configuration stuff in the readme? there is already a section in there describing your installer for Revit 2020. it could be updated now for 2021... thank you!

@jeremytammik
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants