-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution changes for multi-release building #58
Conversation
hi harry, thank you for the enhancement! did you grab the latest version for 2021 before adding them? i see in your solution file mentions VS 15 whereas mine states VS 14... will that cause a problem for other developers using older versions of VS than you do, such as me? |
sign.bat uses your specific signature files... is this if use to others? can it be switched off if not signing? if i merge your pull request, will i be able to build myself at all, without signing? |
this all looks rather harry-specific and i worry whether i will be able to work with it at all myself... same for others, of course... |
Use Visual Studio 2015 Remove extraneous configurations
Hi Jeremy - I just pushed a new version built with Visual Studio 2015
…On Mon, Apr 13, 2020 at 6:03 PM Jeremy Tammik ***@***.***> wrote:
hi harry, thank you for the enhancement! did you grab the latest version
for 2021 before adding them? i see in your solution file mentions VS 15
whereas mine states VS 14... will that cause a problem for other developers
using older versions of VS than you do, such as me?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAROBGHZWYWFAOJHJ4FOUULRMODZNANCNFSM4MHBNTPQ>
.
|
That line is commented out with the REM statement. So it won't affect
anyone in its current state. I left it there as a guide for other people to
see a nice way to do the signing in a post-build event, but I am happy to
remove it if you'd like.
…On Mon, Apr 13, 2020 at 6:05 PM Jeremy Tammik ***@***.***> wrote:
sign.bat uses your specific signature files... is this if use to others?
can it be switched off if not signing? if i merge your pull request, will i
be able to build myself at all, without signing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAROBGEDO2GNZLGGZICYRNLRMOEBNANCNFSM4MHBNTPQ>
.
|
It is designed to be very generic and not at all specific to me or anyone
else. What looks problematic?
…On Mon, Apr 13, 2020 at 6:06 PM Jeremy Tammik ***@***.***> wrote:
this all looks rather harry-specific and i worry whether i will be able to
work with it at all myself... same for others, of course...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAROBGGBXYU677AKB5LT2XTRMOEFLANCNFSM4MHBNTPQ>
.
|
great, i'll take your word for it then. i noticed the REM and then forgot about it again. thank you very much for your contribution! integrating and testing next. |
…or multi-release building
i integrated your changes, compiled, failed (no config defined), set the configuration to 2021, recompiled, and all works well. published as release https://github.com/jeremytammik/RevitLookup/releases/tag/2021.0.0.1. can you check that my steps described above did not overwrite anything crucial for the multi-platform config? maybe now variables have been replaced by constants somewhere? thank you! |
would you like to update the notes on the multi-configuration stuff in the readme? there is already a section in there describing your installer for Revit 2020. it could be updated now for 2021... thank you! |
Create a signed MSI installer using Advanced Installer
Modify the Visual Studio solution to use macro variables to ease the process of building for different Revit version. All you need to do now is create a new configuration and the output direction, DLL references, and other items will automatically update