Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeless windows #93

Merged
merged 7 commits into from
Oct 16, 2021
Merged

Modeless windows #93

merged 7 commits into from
Oct 16, 2021

Conversation

NeVeSpl
Copy link
Contributor

@NeVeSpl NeVeSpl commented Oct 16, 2021

That required more changes than I expected, but the final effect is quite nice. I hope that I have not broken any existing functionality.

@jeremytammik
Copy link
Owner

jeremytammik commented Oct 16, 2021

wow! this is the most exciting pull request ever. fraught with risk, of course. cool. thank you very much for this brilliant contribution. i'll try to take a careful look and test a bit before final integration into main codestream.

@jeremytammik
Copy link
Owner

i see one very apt comment:

		// TBD: For the Snoop.Data.ElementId object I need access to the current
		// document so I can retrieve the Element.  However, from the context of something
		// like a Parameter.AsElementId(), the Document is nowhere to be found.  So, hack
		// around it for now by letting original TestCmd set this value.  Its not local-enough
		// when browsing though, so it could be wrong if browsing doesn't stay within the 
		// original document! (jma - 05/03/05)

would it be easy to implement a warning message when the user (inadvertently) swaps to a different document?

easier than implementing the full solution?

@jeremytammik jeremytammik merged commit 1f826b7 into jeremytammik:master Oct 16, 2021
@NeVeSpl
Copy link
Contributor Author

NeVeSpl commented Oct 16, 2021

I must admit I have not looked into CollectorExtElement and *Stream classes to check how they determine on which document they are working, but they definitely did not use static public Autodesk.Revit.DB.Document m_activeDoc = null; which was below that comment. I will look into that deeper, but after first a few clicks switching documents does not seem to cause any problems...

@NeVeSpl
Copy link
Contributor Author

NeVeSpl commented Oct 17, 2021

Indeed, there is a problem after switching to a different document, I will address that in the next PR.

@jeremytammik
Copy link
Owner

brilliant! Thank you very much for taking such a careful look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants