-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modeless windows #93
Modeless windows #93
Conversation
…longer needed code
…t from Collectors
… way to communicate with revit from outside of its context
wow! this is the most exciting pull request ever. fraught with risk, of course. cool. thank you very much for this brilliant contribution. i'll try to take a careful look and test a bit before final integration into main codestream. |
i see one very apt comment:
would it be easy to implement a warning message when the user (inadvertently) swaps to a different document? easier than implementing the full solution? |
I must admit I have not looked into CollectorExtElement and *Stream classes to check how they determine on which document they are working, but they definitely did not use |
Indeed, there is a problem after switching to a different document, I will address that in the next PR. |
brilliant! Thank you very much for taking such a careful look! |
That required more changes than I expected, but the final effect is quite nice. I hope that I have not broken any existing functionality.