Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add {testthat} test suite; first few tests #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

datawookie
Copy link
Contributor

Hi @jeroen, after tinkering with {gpg} a while ago I been working with the package a lot and it's really useful. I thought that it would make the overall package more robust (and facilitate any further development) if there was a test suite. So I've started to work on that, putting together the first few tests. Didn't want to go too far down this rabbit hole until I was sure that you were open to the idea. So submitting this PR early, with the intention of collaborating and adding more tests over time. Thanks, Andrew.

@jeroen
Copy link
Owner

jeroen commented Apr 8, 2022

Why is it loading stringi?

@datawookie
Copy link
Contributor Author

Good point. Initial implementation used {stringi} to generate random strings. However, I remembered from last time that you are sensitive to the number of dependencies, so I implemented custom function to do this. Just forgot to not load {stringi}. Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants