Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest hashbrown, fix determinism of build #90

Merged

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Jul 8, 2020

This PR updates hashbrown to the latest release (0.8.0).

In the 0.6 series hashbrown's default feature set activated the compile-time-rng-feature in ahash, the internally used hasher – which lead to non-deterministic builds even on the same system. In the latest series this feature is not enabled by hashbrown by default anymore. Updating to that series fixes that problem.

As far as I can tell, this could be released as a non-breaking patch release.

@codecov-commenter
Copy link

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files           1        1           
  Lines         962      962           
=======================================
  Hits          958      958           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5786d33...3b25f8f. Read the comment docs.

@jeromefroe
Copy link
Owner

Hi @gnunicorn, thanks for the PR! I'm happy to land this change, out of an abundance of caution though, I think I'll release it as a new minor version (i.e. 0.6.0). I just worry someone may have an edge case which causes the version bump to break for them. What do you think?

@Ralith Ralith mentioned this pull request Aug 1, 2020
@Ralith
Copy link

Ralith commented Aug 1, 2020

When the major version is 0, cargo treats the minor version as the major version, so that should be a very safe approach.

@jeromefroe
Copy link
Owner

Will go ahead and merge this and then release 0.6.0.

@jeromefroe jeromefroe merged commit 64fd915 into jeromefroe:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants