Alerta matches fix #1068
Merged
Alerta matches fix #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakotacody
added a commit
to dakotacody/elastalert2
that referenced
this pull request
Dec 29, 2022
Changes related to jertel#1068
|
Thanks for the submission. I'll leave this open for a few days to allow others to provide feedback. (Giving people a little extra time due to the holidays.) |
jertel
previously approved these changes
Jan 2, 2023
|
You marked the checklist item for having updating the changelog but I don't see it in this PR. Did you not commit and push that change yet? |
jertel
approved these changes
Jan 4, 2023
|
Relates to #1060. |
|
Thanks @jertel I was on vacation last week and didn't see the updates! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make test-dockerwith my changes.Questions or Comments