Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alerter for IRIS IRP system #1301

Merged
merged 8 commits into from
Oct 27, 2023
Merged

Add alerter for IRIS IRP system #1301

merged 8 commits into from
Oct 27, 2023

Conversation

malinkinsa
Copy link
Contributor

@malinkinsa malinkinsa commented Oct 23, 2023 •
edited
Loading

Description

Added a new alerter type for the ability to create alerts and cases in the IRIS IRP system.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

jertel
jertel requested changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this useful contribution! I added a few comments to this review. I'll enable the automated tests in the meantime.

elastalert/alerters/iris.py Outdated Show resolved Hide resolved
docs/source/ruletypes.rst Outdated Show resolved Hide resolved
elastalert/loaders.py Outdated Show resolved Hide resolved
elastalert/loaders.py Outdated Show resolved Hide resolved
@jertel
Copy link
Owner

jertel commented Oct 24, 2023

The reason the automation failed is due to the linter finding some white space violations in your new code/tests.

@malinkinsa
Copy link
Contributor Author

malinkinsa commented Oct 24, 2023 •
edited
Loading

I see a problem in the tests, so I'm taking a look.
UDP: Fixed

@malinkinsa
Copy link
Contributor Author

The reason the automation failed is due to the linter finding some white space violations in your new code/tests.

Fixed

jertel
jertel reviewed Oct 24, 2023
View reviewed changes
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. I'll leave it open for a little while to let others offer their feedback.

@jertel jertel merged commit b0824fd into jertel:master Oct 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malinkinsa @jertel